sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
Code

ctdb-tests: Fix typos

Browse Source 
These lines are just wrong:

  try_command_on_node -v $test_node "ip addr show to ${test_node}"
  if -n "$out"; then

The 2nd variable referenced should be $test_ip.  The 2nd line causes
"-n: command not found" because it is missing [] test command
brackets.

Both typos would probably make the test pass unconditionally.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
This commit is contained in:
Martin Schwenke 2022-08-08 18:11:26 +10:00 committed by Amitay Isaacs
parent b88e7322d9
commit 42aedc62e3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ctdb/tests/CLUSTER/complex/11_ctdb_delip_removes_ip.sh
View File

@ -26,8 +26,8 @@ increment=5
count=0 count=0
echo "Waiting for ${test_ip} to disappear from node ${test_node}..." echo "Waiting for ${test_ip} to disappear from node ${test_node}..."
while :; do while :; do
try_command_on_node -v $test_node "ip addr show to ${test_node}" try_command_on_node -v $test_node "ip addr show to ${test_ip}"
if -n "$out"; then if [ -n "$out" ]; then
echo "Still there..." echo "Still there..."
if [ $(($count * $increment)) -ge $timeout ]; then if [ $(($count * $increment)) -ge $timeout ]; then
echo "BAD: Timed out waiting..." echo "BAD: Timed out waiting..."