sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-03 04:23:50 +03:00
Code Activity

r14653: make sure we always have a valid session_info

Browse Source 
metze
This commit is contained in:
Stefan Metzmacher
2006-03-22 16:23:19 +00:00
committed by Gerald (Jerry) Carter
parent 2c53c63590
commit 42b3f83d1c
2 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
source/rpc_server/dcerpc_server.c
View File

@@ -289,15 +289,25 @@ static int dcesrv_endpoint_destructor(void *ptr)
NTSTATUS dcesrv_endpoint_connect(struct dcesrv_context *dce_ctx, NTSTATUS dcesrv_endpoint_connect(struct dcesrv_context *dce_ctx,
TALLOC_CTX *mem_ctx, TALLOC_CTX *mem_ctx,
const struct dcesrv_endpoint *ep, const struct dcesrv_endpoint *ep,
struct auth_session_info *session_info,
struct event_context *event_ctx, struct event_context *event_ctx,
uint32_t state_flags, uint32_t state_flags,
struct dcesrv_connection **_p) struct dcesrv_connection **_p)
{ {
struct dcesrv_connection *p; struct dcesrv_connection *p;
if (!session_info) {
return NT_STATUS_ACCESS_DENIED;
}
p = talloc(mem_ctx, struct dcesrv_connection); p = talloc(mem_ctx, struct dcesrv_connection);
NT_STATUS_HAVE_NO_MEMORY(p); NT_STATUS_HAVE_NO_MEMORY(p);
if (!talloc_reference(p, session_info)) {
talloc_free(p);
return NT_STATUS_NO_MEMORY;
}
p->dce_ctx = dce_ctx; p->dce_ctx = dce_ctx;
p->endpoint = ep; p->endpoint = ep;
p->contexts = NULL; p->contexts = NULL;
@@ -307,7 +317,7 @@ NTSTATUS dcesrv_endpoint_connect(struct dcesrv_context *dce_ctx,
p->partial_input = data_blob(NULL, 0); p->partial_input = data_blob(NULL, 0);
p->auth_state.auth_info = NULL; p->auth_state.auth_info = NULL;
p->auth_state.gensec_security = NULL; p->auth_state.gensec_security = NULL;
p->auth_state.session_info = NULL; p->auth_state.session_info = session_info;
p->auth_state.session_key = dcesrv_generic_session_key; p->auth_state.session_key = dcesrv_generic_session_key;
p->event_ctx = event_ctx; p->event_ctx = event_ctx;
p->processing = False; p->processing = False;
@@ -340,12 +350,9 @@ NTSTATUS dcesrv_endpoint_search_connect(struct dcesrv_context *dce_ctx,
return NT_STATUS_OBJECT_NAME_NOT_FOUND; return NT_STATUS_OBJECT_NAME_NOT_FOUND;
} }
status = dcesrv_endpoint_connect(dce_ctx, mem_ctx, ep, event_ctx, state_flags, dce_conn_p); status = dcesrv_endpoint_connect(dce_ctx, mem_ctx, ep, session_info, event_ctx, state_flags, dce_conn_p);
if (!NT_STATUS_IS_OK(status)) { NT_STATUS_NOT_OK_RETURN(status);
return status;
}
(*dce_conn_p)->auth_state.session_info = talloc_reference((*dce_conn_p), session_info);
(*dce_conn_p)->auth_state.session_key = dcesrv_inherited_session_key; (*dce_conn_p)->auth_state.session_key = dcesrv_inherited_session_key;
/* TODO: check security descriptor of the endpoint here /* TODO: check security descriptor of the endpoint here

11
source/rpc_server/dcerpc_sock.c
View File

@@ -31,6 +31,7 @@
#include "lib/messaging/irpc.h" #include "lib/messaging/irpc.h"
#include "system/network.h" #include "system/network.h"
#include "netif/netif.h" #include "netif/netif.h"
#include "auth/auth.h"
struct dcesrv_socket_context { struct dcesrv_socket_context {
const struct dcesrv_endpoint *endpoint; const struct dcesrv_endpoint *endpoint;
@@ -97,10 +98,20 @@ static void dcesrv_sock_accept(struct stream_connection *srv_conn)
struct dcesrv_socket_context *dcesrv_sock = struct dcesrv_socket_context *dcesrv_sock =
talloc_get_type(srv_conn->private, struct dcesrv_socket_context); talloc_get_type(srv_conn->private, struct dcesrv_socket_context);
struct dcesrv_connection *dcesrv_conn = NULL; struct dcesrv_connection *dcesrv_conn = NULL;
struct auth_session_info *session_info = NULL;
status = auth_anonymous_session_info(srv_conn, &session_info);
if (!NT_STATUS_IS_OK(status)) {
DEBUG(0,("dcesrv_sock_accept: auth_anonymous_session_info failed: %s\n",
nt_errstr(status)));
stream_terminate_connection(srv_conn, nt_errstr(status));
return;
}
status = dcesrv_endpoint_connect(dcesrv_sock->dcesrv_ctx, status = dcesrv_endpoint_connect(dcesrv_sock->dcesrv_ctx,
srv_conn, srv_conn,
dcesrv_sock->endpoint, dcesrv_sock->endpoint,
session_info,
srv_conn->event.ctx, srv_conn->event.ctx,
DCESRV_CALL_STATE_FLAG_MAY_ASYNC, DCESRV_CALL_STATE_FLAG_MAY_ASYNC,
&dcesrv_conn); &dcesrv_conn);