sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00
Code

r14014: Coverity paranoia. Shut it up by making the guarentee

Browse Source 
in the code explicit - but this was a false positive (CID #16).
Jeremy.
This commit is contained in:
Jeremy Allison 2006-03-08 06:16:54 +00:00 committed by Gerald (Jerry) Carter
parent af0ade470f
commit 43a0e869f2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source/rpc_parse/parse_buffer.c
View File

@ -47,7 +47,7 @@ BOOL prs_rpcbuffer(const char *desc, prs_struct *ps, int depth, RPC_BUFFER *buff
{ {
prs_debug(ps, depth, desc, "prs_rpcbuffer"); prs_debug(ps, depth, desc, "prs_rpcbuffer");
depth++; depth++;
/* reading */ /* reading */
if (UNMARSHALLING(ps)) { if (UNMARSHALLING(ps)) {
buffer->size=0; buffer->size=0;
@ -135,7 +135,12 @@ BOOL prs_rpcbuffer_p(const char *desc, prs_struct *ps, int depth, RPC_BUFFER **b
} }
return True; return True;
} }
/* Coverity paranoia. Buffer must be valid. */
if (!*buffer) {
return False;
}
return prs_rpcbuffer( desc, ps, depth, *buffer); return prs_rpcbuffer( desc, ps, depth, *buffer);
} }