sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

iniparser: Fix CID 241908 Copy into fixed size buffer

Browse Source 
strcpy is never a good idea....

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
This commit is contained in:
Volker Lendecke 2013-11-09 20:37:01 +01:00 committed by Ira Cooper
parent 1cae867f72
commit 43ac7e81ec
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/iniparser/src/iniparser.c
View File

@ -38,16 +38,18 @@ static void iniparser_add_entry(
char * val)
{
char longkey[2*ASCIILINESZ+1];
char *l;
/* Make a key as section:keyword */
if (key!=NULL) {
sprintf(longkey, "%s:%s", sec, key);
snprintf(longkey, sizeof(longkey), "%s:%s", sec, key);
l = longkey;
} else {
strcpy(longkey, sec);
l = sec;
}
/* Add (key,val) to dictionary */
dictionary_set(d, longkey, val);
dictionary_set(d, l, val);
return ;
}