sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-27 22:50:26 +03:00
Code

s4:rpc_server: it's not a protocol error to do an alter context with an unknown transfer syntax

Browse Source 
Windows 2012R2 only returns a protocol error if the client wants to change
between supported transfer syntaxes, e.g. from NDR32 to NDR64.

If the proposed transfer syntax is not known to the server,
the request will be silently ignored.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Stefan Metzmacher 2016-08-30 14:35:34 +02:00 committed by Andreas Schneider
parent 3d179d86fa
commit 450e00a8a7
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
selftest/knownfail
View File

@ -294,3 +294,6 @@
#ntvfs server blocks copychunk with execute access on read handle
^samba4.smb2.ioctl.copy_chunk_bad_access
^samba4.drs.getnc_exop.python.*getnc_exop.DrsReplicaPrefixMapTestCase.test_regular_prefix_map_ex_attid.*
# We don't support NDR64 yet, so we generate the wrong FAULT code
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_spnego_change_auth_type2
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_spnego_change_transfer

6
source4/rpc_server/dcerpc_server.c
View File

@ -989,10 +989,6 @@ static NTSTATUS dcesrv_check_or_create_context(struct dcesrv_call_state *call,
return NT_STATUS_RPC_PROTOCOL_ERROR;
}
if (ctx->num_transfer_syntaxes != 1) {
return NT_STATUS_RPC_PROTOCOL_ERROR;
}
if (selected_transfer != NULL) {
ok = ndr_syntax_id_equal(&context->transfer_syntax,
selected_transfer);
@ -1003,8 +999,6 @@ static NTSTATUS dcesrv_check_or_create_context(struct dcesrv_call_state *call,
ack->result = DCERPC_BIND_ACK_RESULT_ACCEPTANCE;
ack->reason.value = DCERPC_BIND_ACK_REASON_NOT_SPECIFIED;
ack->syntax = context->transfer_syntax;
} else {
return NT_STATUS_RPC_PROTOCOL_ERROR;
}
/*