sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

s3-vfs: Remove extra calls to SMB_VFS_HANDLE_GET_DATA

Browse Source 
Found by the talloc_stackframe() out of order checker!

Andrew Bartlett
This commit is contained in:
Andrew Bartlett 2012-08-21 21:22:31 +10:00
parent 2b404462f5
commit 450fcd79c7
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source3/modules/vfs_xattr_tdb.c
View File

@ -150,8 +150,6 @@ static int xattr_tdb_setxattr(struct vfs_handle_struct *handle,
TALLOC_FREE(frame); return -1; TALLOC_FREE(frame); return -1;
}); });
SMB_VFS_HANDLE_GET_DATA(handle, db, struct db_context, return -1);
ret = xattr_tdb_get_file_id(handle, path, &id); ret = xattr_tdb_get_file_id(handle, path, &id);
if (ret == -1) { if (ret == -1) {
TALLOC_FREE(frame); TALLOC_FREE(frame);
@ -207,8 +205,6 @@ static ssize_t xattr_tdb_listxattr(struct vfs_handle_struct *handle,
TALLOC_FREE(frame); return -1; TALLOC_FREE(frame); return -1;
}); });
SMB_VFS_HANDLE_GET_DATA(handle, db, struct db_context, return -1);
ret = xattr_tdb_get_file_id(handle, path, &id); ret = xattr_tdb_get_file_id(handle, path, &id);
if (ret == -1) { if (ret == -1) {
TALLOC_FREE(frame); TALLOC_FREE(frame);
@ -263,8 +259,6 @@ static int xattr_tdb_removexattr(struct vfs_handle_struct *handle,
TALLOC_FREE(frame); return -1; TALLOC_FREE(frame); return -1;
}); });
SMB_VFS_HANDLE_GET_DATA(handle, db, struct db_context, TALLOC_FREE(frame); return -1);
ret = xattr_tdb_get_file_id(handle, path, &id); ret = xattr_tdb_get_file_id(handle, path, &id);
if (ret == -1) { if (ret == -1) {
TALLOC_FREE(frame); TALLOC_FREE(frame);