sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-31 20:22:15 +03:00
Code Activity

s4: use ldb_msg_new(), not talloc/talloc_zero

Browse Source 
ldb_msg_new() is currently the same as talloc_zero(), but it might
not always be.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall
2019-04-15 23:20:46 +12:00
committed by Andrew Bartlett
parent 8f081b7f78
commit 4624957d42
3 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source4/dsdb/samdb/ldb_modules/dirsync.c
View File

@ -150,7 +150,7 @@ static int dirsync_filter_entry(struct ldb_request *req,
* list only the attribute that have been modified since last interogation * list only the attribute that have been modified since last interogation
* *
*/ */
newmsg = talloc_zero(dsc->req, struct ldb_message); newmsg = ldb_msg_new(dsc->req);
if (newmsg == NULL) { if (newmsg == NULL) {
return ldb_oom(ldb); return ldb_oom(ldb);
} }

4
source4/ldap_server/ldap_backend.c
View File

@ -799,12 +799,10 @@ static NTSTATUS ldapsrv_ModifyRequest(struct ldapsrv_call *call)
DEBUG(10, ("ModifyRequest: dn: [%s]\n", req->dn)); DEBUG(10, ("ModifyRequest: dn: [%s]\n", req->dn));
msg = talloc(local_ctx, struct ldb_message); msg = ldb_msg_new(local_ctx);
NT_STATUS_HAVE_NO_MEMORY(msg); NT_STATUS_HAVE_NO_MEMORY(msg);
msg->dn = dn; msg->dn = dn;
msg->num_elements = 0;
msg->elements = NULL;
if (req->num_mods > 0) { if (req->num_mods > 0) {
msg->num_elements = req->num_mods; msg->num_elements = req->num_mods;

4
source4/lib/registry/ldb.c
View File

@ -142,7 +142,7 @@ static struct ldb_message *reg_ldb_pack_value(struct ldb_context *ctx,
char *name_dup, *type_str; char *name_dup, *type_str;
int ret; int ret;
msg = talloc_zero(mem_ctx, struct ldb_message); msg = ldb_msg_new(mem_ctx);
if (msg == NULL) { if (msg == NULL) {
return NULL; return NULL;
} }
@ -658,7 +658,7 @@ static WERROR ldb_del_value(TALLOC_CTX *mem_ctx, struct hive_key *key,
if (child[0] == '\0') { if (child[0] == '\0') {
/* default value */ /* default value */
msg = talloc_zero(mem_ctx, struct ldb_message); msg = ldb_msg_new(mem_ctx);
W_ERROR_HAVE_NO_MEMORY(msg); W_ERROR_HAVE_NO_MEMORY(msg);
msg->dn = ldb_dn_copy(msg, kd->dn); msg->dn = ldb_dn_copy(msg, kd->dn);
W_ERROR_HAVE_NO_MEMORY(msg->dn); W_ERROR_HAVE_NO_MEMORY(msg->dn);