sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

s3:smbd: don't allow renaming basefile if streams are open

Browse Source 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2018-05-26 18:32:21 +02:00 committed by Jeremy Allison
parent dd8cf54c79
commit 465b7d07e5
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
selftest/knownfail.d/samba3.smb2.streams
View File

@ -1,2 +0,0 @@
samba3.smb2.streams.basefile-rename-with-open-stream\(.*\)
samba3.smb2.streams streams_xattr.basefile-rename-with-open-stream\(nt4_dc\)

3
selftest/knownfail.d/samba3.vfs.fruit
View File

@ -1,4 +1 @@
^samba3.vfs.fruit streams_depot.OS X AppleDouble file conversion\(nt4_dc\)
^samba3.vfs.fruit metadata_netatalk.read open rsrc after rename\(nt4_dc\)
^samba3.vfs.fruit metadata_stream.read open rsrc after rename\(nt4_dc\)
^samba3.vfs.fruit streams_depot.read open rsrc after rename\(nt4_dc\)

4
source3/smbd/reply.c
View File

@ -6643,6 +6643,10 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
return status;
}
if (file_has_open_streams(fsp)) {
return NT_STATUS_ACCESS_DENIED;
}
/* Make a copy of the dst smb_fname structs */
smb_fname_dst = cp_smb_filename(ctx, smb_fname_dst_in);