sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-27 22:50:26 +03:00
Code

s4:torture/vfs/fruit: update test "creating rsrc with read-only access" for newer macOS versions

Browse Source 
While this operation failed against older macOS versions, it passes
against versions 10.12 and newer. Update the test accordingly, a
subsequent commit will then update our implementation.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c3cf09a0791ed4dfb7ca18d175396ac1aca5d2ed)
This commit is contained in:
Ralph Boehme 2018-10-15 15:17:08 +02:00 committed by Karolin Seeger
parent a14fe5b863
commit 46c5c8ab37
2 changed files with 4 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
selftest/knownfail.d/samba3.vfs.fruit
View File

@ -1,2 +1,5 @@
^samba3.vfs.fruit streams_depot.OS X AppleDouble file conversion\(nt4_dc\)
^samba3.vfs.fruit streams_depot.OS X AppleDouble file conversion without embedded xattr\(nt4_dc\)
^samba3.vfs.fruit metadata_netatalk.creating rsrc with read-only access\(nt4_dc\)
^samba3.vfs.fruit metadata_stream.creating rsrc with read-only access\(nt4_dc\)
^samba3.vfs.fruit streams_depot.creating rsrc with read-only access\(nt4_dc\)

28
source4/torture/vfs/fruit.c
View File

@ -2045,35 +2045,9 @@ static bool test_rfork_create_ro(struct torture_context *tctx,
}
torture_comment(tctx, "(%s) Try opening read-only with "
"open_if create disposition, should return ENOENT\n",
"open_if create disposition, should work\n",
__location__);
ZERO_STRUCT(create);
create.in.fname = rfork;
create.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
create.in.desired_access = SEC_FILE_READ_DATA | SEC_STD_READ_CONTROL;
create.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
create.in.share_access = FILE_SHARE_READ | FILE_SHARE_DELETE;
status = smb2_create(tree, mem_ctx, &(create));
torture_assert_ntstatus_equal_goto(tctx, status,
NT_STATUS_OBJECT_NAME_NOT_FOUND,
ret, done, "smb2_create failed\n");
torture_comment(tctx, "(%s) Now write something to the "
"rsrc stream, then the same open should succeed\n",
__location__);
ret = write_stream(tree, __location__, tctx, mem_ctx,
fname, AFPRESOURCE_STREAM_NAME,
0, 3, "foo");
torture_assert_goto(tctx, ret == true, ret, done,
"write_stream failed\n");
ret = check_stream(tree, __location__, tctx, mem_ctx,
fname, AFPRESOURCE_STREAM,
0, 3, 0, 3, "foo");
torture_assert_goto(tctx, ret == true, ret, done, "check_stream");
ZERO_STRUCT(create);
create.in.fname = rfork;
create.in.create_disposition = NTCREATEX_DISP_OPEN_IF;