sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

ctdb-daemon: Do not process tickle updates for hosted IP addresses

Browse Source 
Tickle list updates are broadcast to all connected nodes and are
accepted even when received on the same node that sent them.  This
could actually lead to lost connection information when information
about new connections is received while an update is in-flight.

Instead, return early when the IP is hosted on the current node, since
it is the only one that could have sent the update.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
This commit is contained in:
Martin Schwenke 2015-03-27 15:30:16 +11:00 committed by Amitay Isaacs
parent 80c0511421
commit 473f1a77e1
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ctdb/server/ctdb_takeover.c
View File

@ -3812,6 +3812,13 @@ int32_t ctdb_control_set_tcp_tickle_list(struct ctdb_context *ctdb, TDB_DATA ind
return 1;
}
if (vnn->pnn == ctdb->pnn) {
DEBUG(DEBUG_INFO,
("Ignoring redundant set tcp tickle list, this node hosts '%s'\n",
ctdb_addr_to_str(&list->addr)));
return 0;
}
/* remove any old ticklelist we might have */
talloc_free(vnn->tcp_array);
vnn->tcp_array = NULL;