sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

selftest: enable py3 for samba.tests.samdb_api

Browse Source 
Fix bytes and string.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
This commit is contained in:
Joe Guo 2018-04-05 10:47:16 +12:00 committed by Andrew Bartlett
parent ff66428201
commit 47761ee449
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
python/samba/tests/samdb_api.py
View File

@ -72,15 +72,15 @@ class SamDBApiTestCase(TestCaseInTempDir):
#
def test_create_db_existing_file_non_tdb_file(self):
existing_name = self.tempdir + "/existing.db"
existing = open(existing_name, "w")
existing.write("This is not a tdb file!!!!!!")
existing = open(existing_name, "wb")
existing.write(b"This is not a tdb file!!!!!!")
existing.close()
SamDB(url="tdb://" + existing_name, flags=0)
existing = open(existing_name, "r")
existing = open(existing_name, "rb")
contents = existing.readline()
self.assertEquals("TDB file\n", contents)
self.assertEquals(b"TDB file\n", contents)
#
# Attempt to open an existing tdb file as a tdb file.
@ -99,11 +99,11 @@ class SamDBApiTestCase(TestCaseInTempDir):
})
cn = initial.searchone("cn", dn)
self.assertEquals("test_dont_create_db_existing_tdb_file", cn)
self.assertEquals(b"test_dont_create_db_existing_tdb_file", cn)
second = SamDB(url="tdb://" + existing_name)
cn = second.searchone("cn", dn)
self.assertEquals("test_dont_create_db_existing_tdb_file", cn)
self.assertEquals(b"test_dont_create_db_existing_tdb_file", cn)
#
# Attempt to open an existing tdb file as a tdb file.
@ -122,11 +122,11 @@ class SamDBApiTestCase(TestCaseInTempDir):
})
cn = initial.searchone("cn", dn)
self.assertEquals("test_dont_create_db_existing_tdb_file", cn)
self.assertEquals(b"test_dont_create_db_existing_tdb_file", cn)
second = SamDB(url="tdb://" + existing_name, flags=0)
cn = second.searchone("cn", dn)
self.assertEquals("test_dont_create_db_existing_tdb_file", cn)
self.assertEquals(b"test_dont_create_db_existing_tdb_file", cn)
# Open a non existent TDB file.
# Don't create new db is set, the default
@ -155,6 +155,6 @@ class SamDBApiTestCase(TestCaseInTempDir):
#
def test_create_db_new_file(self):
SamDB(url="tdb://" + self.tempdir + "/test.db", flags=0)
existing = open(self.tempdir + "/test.db", "r")
existing = open(self.tempdir + "/test.db", mode="rb")
contents = existing.readline()
self.assertEquals("TDB file\n", contents)
self.assertEquals(b"TDB file\n", contents)

2
selftest/tests.py
View File

@ -156,7 +156,7 @@ planpythontestsuite("none", "samba.tests.graph")
plantestsuite("wafsamba.duplicate_symbols", "none", [os.path.join(srcdir(), "buildtools/wafsamba/test_duplicate_symbol.sh")])
planpythontestsuite("none", "samba.tests.glue", py3_compatible=True)
planpythontestsuite("none", "samba.tests.tdb_util", py3_compatible=True)
planpythontestsuite("none", "samba.tests.samdb_api")
planpythontestsuite("none", "samba.tests.samdb_api", py3_compatible=True)
if with_pam:
plantestsuite("samba.tests.pam_winbind(local)", "ad_member",