From 4806f0505e3ab6cd1aedd0e79c81e3a87afb9b18 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 21 Nov 2017 20:30:08 +0100 Subject: [PATCH] libgpo: Fix CID 1422262 Explicit null dereferenced Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- libgpo/pygpo.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c index a54ddb98fe7..619985239cb 100644 --- a/libgpo/pygpo.c +++ b/libgpo/pygpo.c @@ -175,12 +175,16 @@ static int py_ads_init(ADS *self, PyObject *args, PyObject *kwds) } if (lp_obj) { + bool ok; lp_ctx = pytalloc_get_type(lp_obj, struct loadparm_context); if (lp_ctx == NULL) { return -1; } + ok = lp_load_initial_only(lp_ctx->szConfigFile); + if (!ok) { + return -1; + } } - if (!lp_load_initial_only(lp_ctx->szConfigFile)) return -1; if (self->cli_creds) { realm = cli_credentials_get_realm(self->cli_creds);