1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00

fruit: Fix CID 1323186 Dereference before null check

In all other "goto fail;" paths we had already dereferenced fsp,
so the if-statement checking for fsp!=NULL was unnecessary. This
fix gives us an additional error message in case check_aapl fails.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep  8 13:47:01 CEST 2015 on sn-devel-104
This commit is contained in:
Volker Lendecke 2015-09-08 08:18:02 +02:00 committed by Michael Adam
parent 04c8655719
commit 48d4aac563

View File

@ -3318,7 +3318,7 @@ static NTSTATUS fruit_create_file(vfs_handle_struct *handle,
status = check_aapl(handle, req, in_context_blobs, out_context_blobs); status = check_aapl(handle, req, in_context_blobs, out_context_blobs);
if (!NT_STATUS_IS_OK(status)) { if (!NT_STATUS_IS_OK(status)) {
return status; goto fail;
} }
SMB_VFS_HANDLE_GET_DATA(handle, config, struct fruit_config_data, SMB_VFS_HANDLE_GET_DATA(handle, config, struct fruit_config_data,