sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

s3:rpc_server/svcctl: don't allocate return values on a temporary stackframe

Browse Source 
And always initialize the whole return structure.

This caused samba3.posix_s3.rpc.svcctl to be flakey.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 11:34:34 CEST 2011 on sn-devel-104
This commit is contained in:
Stefan Metzmacher 2011-06-16 08:33:09 +02:00
parent 03ea6b5b9e
commit 48de3e51ea
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source3/rpc_server/svcctl/srv_svcctl_nt.c
View File

@ -668,17 +668,18 @@ WERROR _svcctl_QueryServiceStatusEx(struct pipes_struct *p,
/********************************************************************
********************************************************************/
static WERROR fill_svc_config(TALLOC_CTX *ctx,
static WERROR fill_svc_config(TALLOC_CTX *mem_ctx,
struct messaging_context *msg_ctx,
struct auth_serversupplied_info *session_info,
const char *name,
struct QUERY_SERVICE_CONFIG *config)
{
TALLOC_CTX *mem_ctx = talloc_stackframe();
const char *result = NULL;
/* now fill in the individual values */
ZERO_STRUCTP(config);
config->displayname = svcctl_lookup_dispname(mem_ctx,
msg_ctx,
session_info,
@ -720,9 +721,6 @@ static WERROR fill_svc_config(TALLOC_CTX *ctx,
else
config->start_type = SVCCTL_DEMAND_START;
talloc_free(mem_ctx);
return WERR_OK;
}