sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

libprc ndr tests: Fix ndrdump test ntlmssp_CHALLENGE_MESSAGE

Browse Source 
Fix the expected data in fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt, as it
contained source code line numbers.

Andrew this test needs to be altered to us a regular expression and
remove the dependency on source line numbers.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20083
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14236

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Gary Lockyer 2020-02-07 10:50:07 +13:00 committed by Andrew Bartlett
parent 14182350f8
commit 490bbb96b9
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/bug-14236
View File

@ -1 +0,0 @@
^samba.tests.blackbox.ndrdump.samba.tests.blackbox.ndrdump.NdrDumpTests.test_ndrdump_fuzzed_NULL_struct_ntlmssp_CHALLENGE_MESSAGE

2
source4/librpc/tests/fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt
View File

@ -38,6 +38,6 @@ pull returned Success
TargetInfoLen : 0x0000 (0) TargetInfoLen : 0x0000 (0)
TargetInfoMaxLen : 0x0000 (0) TargetInfoMaxLen : 0x0000 (0)
TargetInfo : NULL TargetInfo : NULL
ndr_push_subcontext_end: ndr_push_error(Subcontext Error): Bad subcontext (PUSH) content_size 1 is larger than size_is(0) at ../../librpc/ndr/ndr.c:905 ndr_push_subcontext_end: ndr_push_error(Subcontext Error): Bad subcontext (PUSH) content_size 1 is larger than size_is(0) at ../../librpc/ndr/ndr.c:901
push returned Subcontext Error push returned Subcontext Error
validate push FAILED validate push FAILED