1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00

If signing starts successfully, don't just turn it off automatically if

it fails later. Only turn it off automatically if it fails at the start.
Jeremy.
This commit is contained in:
Jeremy Allison 0001-01-01 00:00:00 +00:00
parent 48123f7e42
commit 4a145531c2

View File

@ -745,11 +745,8 @@ We were expecting seq %u\n", reply_seq_number, saved_seq ));
}
if (!signing_good(inbuf, si, good, saved_seq)) {
if (si->mandatory_signing) {
/* Mandatory signing - fail and disconnect. */
return False;
} else {
/* Non-mandatory signing - just turn off. */
if (!si->mandatory_signing && (data->send_seq_num < 3)){
/* Non-mandatory signing - just turn off if this is the first bad packet.. */
DEBUG(5, ("srv_check_incoming_message: signing negotiated but not required and client \
isn't sending correct signatures. Turning off.\n"));
si->negotiated_smb_signing = False;
@ -757,6 +754,9 @@ isn't sending correct signatures. Turning off.\n"));
si->doing_signing = False;
free_signing_context(si);
return True;
} else {
/* Mandatory signing or bad packet after signing started - fail and disconnect. */
return False;
}
} else {
return True;