sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

gensec_krb5: Do not leak memory of target_principal

Browse Source 
CID 1372504

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Sep  9 04:20:04 CEST 2016 on sn-devel-144
This commit is contained in:
Andreas Schneider 2016-09-06 12:09:47 +02:00 committed by Jeremy Allison
parent 1cbdfe91fe
commit 4a8b588dc0
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source4/auth/gensec/gensec_krb5.c
View File

@ -339,12 +339,16 @@ static NTSTATUS gensec_krb5_common_client_creds(struct gensec_security *gensec_s
ccache_container->ccache,
&this_cred.client);
if (ret != 0) {
krb5_free_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
target_principal);
return NT_STATUS_UNSUCCESSFUL;
}
ret = krb5_copy_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
target_principal,
&this_cred.server);
krb5_free_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
target_principal);
if (ret != 0) {
krb5_free_cred_contents(gensec_krb5_state->smb_krb5_context->krb5_context,
&this_cred);
@ -369,9 +373,6 @@ static NTSTATUS gensec_krb5_common_client_creds(struct gensec_security *gensec_s
in_data_p,
cred,
&gensec_krb5_state->enc_ticket);
krb5_free_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
target_principal);
}
} else {
ret = krb5_mk_req(gensec_krb5_state->smb_krb5_context->krb5_context,