sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

s3:libsmb:namequery: note intransitivity in addr_compare()

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2024-04-03 16:10:38 +13:00 committed by Andrew Bartlett
parent f07ae69907
commit 4a9d274d43
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source3/libsmb/namequery.c
View File

@ -1087,8 +1087,15 @@ bool name_status_find(const char *q_name,
}
/*
comparison function used by sort_addr_list
*/
* comparison function used by sort_addr_list
*
* This comparison is intransitive in sort if a socket has an invalid
* family (i.e., not IPv4 or IPv6), or an interface doesn't support
* the family. Say we have sockaddrs with IP versions {4,5,6}, of
* which 5 is invalid. By this function, 4 == 5 and 6 == 5, but 4 !=
* 6. This is of course a consequence of cmp() being unable to
* communicate error.
*/
static int addr_compare(const struct sockaddr_storage *ss1,
const struct sockaddr_storage *ss2)