sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

s3:afs: Zero memory for afs_keyfile

Browse Source 
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Pavel Filipenský 2022-08-10 09:07:07 +02:00 committed by Andreas Schneider
parent 83dc061fd3
commit 4b2df80e89
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source3/passdb/secrets.c
View File

@ -430,14 +430,14 @@ bool secrets_fetch_afs_key(const char *cell, struct afs_key *result)
return False;
if (size != sizeof(struct afs_keyfile)) {
SAFE_FREE(keyfile);
BURN_FREE(keyfile, sizeof(*keyfile));
return False;
}
i = ntohl(keyfile->nkeys);
if (i > SECRETS_AFS_MAXKEYS) {
SAFE_FREE(keyfile);
BURN_FREE(keyfile, sizeof(*keyfile));
return False;
}
@ -445,7 +445,7 @@ bool secrets_fetch_afs_key(const char *cell, struct afs_key *result)
result->kvno = ntohl(result->kvno);
SAFE_FREE(keyfile);
BURN_FREE(keyfile, sizeof(*keyfile));
return True;
}

2
source3/utils/net_afs.c
View File

@ -65,9 +65,11 @@ int net_afs_key(struct net_context *c, int argc, const char **argv)
if (!secrets_store_afs_keyfile(argv[1], &keyfile)) {
d_fprintf(stderr, _("Could not write keyfile to secrets.tdb\n"));
ZERO_STRUCT(keyfile);
return -1;
}
ZERO_STRUCT(keyfile);
return 0;
}