sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

getncchanges: Do not filter EXOPs using highwatermark

Browse Source 
Prior to this patch, any REPL_SECRETS could be filtered accidentally.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Garming Sam 2017-05-22 13:59:22 +12:00 committed by Andrew Bartlett
parent b22387cf85
commit 4b52f102be
1 changed files with 25 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
source4/rpc_server/drsuapi/getncchanges.c
View File

@ -2358,28 +2358,35 @@ allowed:
extra_filter = lpcfg_parm_string(dce_call->conn->dce_ctx->lp_ctx, NULL, "drs", "object filter");
if (req10->uptodateness_vector != NULL) {
udv = req10->uptodateness_vector;
if (req10->extended_op == DRSUAPI_EXOP_NONE) {
if (req10->uptodateness_vector != NULL) {
udv = req10->uptodateness_vector;
} else {
udv = &empty_udv;
}
getnc_state->min_usn = req10->highwatermark.highest_usn;
for (i = 0; i < udv->count; i++) {
bool match;
const struct drsuapi_DsReplicaCursor *cur =
&udv->cursors[i];
match = GUID_equal(&invocation_id,
&cur->source_dsa_invocation_id);
if (!match) {
continue;
}
if (cur->highest_usn > getnc_state->min_usn) {
getnc_state->min_usn = cur->highest_usn;
}
break;
}
} else {
/* We do not want REPL_SECRETS or REPL_SINGLE to return empty-handed */
udv = &empty_udv;
getnc_state->min_usn = 0;
}
getnc_state->min_usn = req10->highwatermark.highest_usn;
for (i = 0; i < udv->count; i++) {
bool match;
const struct drsuapi_DsReplicaCursor *cur =
&udv->cursors[i];
match = GUID_equal(&invocation_id,
&cur->source_dsa_invocation_id);
if (!match) {
continue;
}
if (cur->highest_usn > getnc_state->min_usn) {
getnc_state->min_usn = cur->highest_usn;
}
break;
}
getnc_state->max_usn = getnc_state->min_usn;
getnc_state->final_udv = talloc_zero(getnc_state,