sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

Remove NT_STATUS_IS_OK_RETURN macro from the codebase.

Browse Source 
Following the current coding guidelines, it is considered bad practice to return from
within a macro and change control flow as they look like normal function calls.

Change-Id: I27e7597f4078f0a6c96b5dadd12454fffe33e6b2
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Garming Sam 2014-02-14 17:43:25 +13:00 committed by Andreas Schneider
parent d2beff59ec
commit 4c9e0d5add
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source4/ldap_server/ldap_extended.c
View File

@ -185,7 +185,9 @@ NTSTATUS ldapsrv_ExtendedRequest(struct ldapsrv_call *call)
* send and we need to return directly
*/
status = extended_ops[i].fn(call, reply, &error_str);
NT_STATUS_IS_OK_RETURN(status);
if (NT_STATUS_IS_OK(status)) {
return status;
}
if (NT_STATUS_IS_LDAP(status)) {
result = NT_STATUS_LDAP_CODE(status);