sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s3:smbd: remove dead code from smbd_smb2_request_dispatch()

Browse Source 
We have '} else if (signing_required || (flags & SMB2_HDR_FLAG_SIGNED)) {'
before...

Use 'git show -U52' to see the whole story...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f8f4a9faf0)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14788
This commit is contained in:
Stefan Metzmacher 2021-07-13 16:37:42 +02:00 committed by Jule Anger
parent 3d35397e10
commit 4d2d5a3c66
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source3/smbd/smb2_server.c
View File

@ -2717,9 +2717,6 @@ static void smb2srv_update_crypto_flags(struct smbd_smb2_request *req,
/* Unencrypted packet, can be signed */
if (req->do_signing) {
sign_flag = SMBXSRV_PROCESSED_SIGNED_PACKET;
} else if (opcode == SMB2_OP_CANCEL) {
/* Cancel requests are allowed to skip signing */
sign_flag &= ~SMBXSRV_PROCESSED_UNSIGNED_PACKET;
}
}
@ -3080,8 +3077,6 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
if (!NT_STATUS_IS_OK(session_status)) {
return smbd_smb2_request_error(req, session_status);
}
} else if (opcode == SMB2_OP_CANCEL) {
/* Cancel requests are allowed to skip the signing */
} else if (opcode == SMB2_OP_IOCTL) {
/*
* Some special IOCTL calls don't require
@ -3118,13 +3113,6 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
call = &_root_ioctl_call;
break;
}
} else if (signing_required) {
/*
* If signing is required we try to sign
* a possible error response
*/
req->do_signing = true;
return smbd_smb2_request_error(req, NT_STATUS_ACCESS_DENIED);
}
if (flags & SMB2_HDR_FLAG_CHAINED) {