sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-08 04:58:40 +03:00
Code

Tiny logic simplification -- remove an else branch

Browse Source 
(This used to be commit 01c8c7bbf6163d5c7733db0d8ecbccfe7e4fec7d)
This commit is contained in:
Volker Lendecke 2008-07-03 23:34:28 +02:00
parent ca34287063
commit 4dbfa7a211
1 changed files with 21 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
source3/winbindd/winbindd_idmap.c
View File

@ -241,33 +241,31 @@ enum winbindd_result winbindd_dual_sids2xids(struct winbindd_domain *domain,
result = idmap_sids_to_unixids(ids, num);
if (NT_STATUS_IS_OK(result)) {
xids = SMB_MALLOC_ARRAY(struct unixid, num);
if ( ! xids) {
DEBUG(0, ("Out of memory!\n"));
talloc_free(ids);
return WINBINDD_ERROR;
}
for (i = 0; i < num; i++) {
if (ids[i]->status == ID_MAPPED) {
xids[i].type = ids[i]->xid.type;
xids[i].id = ids[i]->xid.id;
} else {
xids[i].type = -1;
}
}
state->response.length = sizeof(state->response) + (sizeof(struct unixid) * num);
state->response.extra_data.data = xids;
} else {
DEBUG (2, ("idmap_sids_to_unixids returned an error: 0x%08x\n", NT_STATUS_V(result)));
if (!NT_STATUS_IS_OK(result)) {
DEBUG (2, ("idmap_sids_to_unixids returned an error: 0x%08x\n",
NT_STATUS_V(result)));
talloc_free(ids);
return WINBINDD_ERROR;
}
xids = SMB_MALLOC_ARRAY(struct unixid, num);
if ( ! xids) {
DEBUG(0, ("Out of memory!\n"));
talloc_free(ids);
return WINBINDD_ERROR;
}
for (i = 0; i < num; i++) {
if (ids[i]->status == ID_MAPPED) {
xids[i].type = ids[i]->xid.type;
xids[i].id = ids[i]->xid.id;
} else {
xids[i].type = -1;
}
}
state->response.length = sizeof(state->response) + (sizeof(struct unixid) * num);
state->response.extra_data.data = xids;
talloc_free(ids);
return WINBINDD_OK;
}