sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code

s4:netlogon RPC - fix the indentation

Browse Source 
Simo, I'm not really sure that those checks are valid. I read MS-NRPC section
3.5.4.1 about LOGONSRV_HANDLEs ("server_name" is of this type). There isn't
stated that the server name has necessarily to be in the DNS form and should
also be valid when it's NULL (if DCE server and client are the same - I don't
know if me make use of it in s4).
This commit is contained in:
Matthias Dieter Wallnöfer 2010-02-23 09:51:25 +01:00
parent 0c8608bbab
commit 4ef82accfe
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
source4/rpc_server/netlogon/dcerpc_netlogon.c
View File

@ -1715,25 +1715,25 @@ static WERROR dcesrv_netr_DsrEnumerateDomainTrusts(struct dcesrv_call_state *dce
}
/* TODO: turn to hard check once we are sure this is 100% correct */
if (!r->in.server_name) {
if (!r->in.server_name) {
DEBUG(3, ("Invalid domain! Expected name in domain [%s]. "
"But received NULL!\n", dnsdomain));
} else {
p = strchr(r->in.server_name, '.');
if (!p) {
DEBUG(3, ("Invalid domain! Expected name in domain "
"[%s]. But received [%s]!\n",
dnsdomain, r->in.server_name));
p = r->in.server_name;
} else {
p++;
} else {
p = strchr(r->in.server_name, '.');
if (!p) {
DEBUG(3, ("Invalid domain! Expected name in domain "
"[%s]. But received [%s]!\n",
dnsdomain, r->in.server_name));
p = r->in.server_name;
} else {
p++;
}
if (strcasecmp(p, dnsdomain)) {
DEBUG(3, ("Invalid domain! Expected name in domain "
"[%s]. But received [%s]!\n",
dnsdomain, r->in.server_name));
}
}
DEBUG(3, ("Invalid domain! Expected name in domain "
"[%s]. But received [%s]!\n",
dnsdomain, r->in.server_name));
}
}
ZERO_STRUCT(r->out);