sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code

libcli/security/dom_sid: use (unsigned char) in isdigit()

Browse Source 
The man page notes:

       The standards require that the argument c for these functions
       is either EOF or a value that is representable in the type
       unsigned char.  If the argument c is of type char, it must be
       cast to unsigned char, as in the following example:

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2023-04-21 15:32:01 +12:00 committed by Andrew Bartlett
parent 1149d39159
commit 4f5737cbf2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libcli/security/dom_sid.c
View File

@ -145,7 +145,7 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
/* Get the revision number. */ /* Get the revision number. */
p = sidstr + 2; p = sidstr + 2;
if (!isdigit(*p)) { if (!isdigit((unsigned char)*p)) {
goto format_error; goto format_error;
} }
@ -156,7 +156,7 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
sidout->sid_rev_num = (uint8_t) conv; sidout->sid_rev_num = (uint8_t) conv;
q++; q++;
if (!isdigit(*q)) { if (!isdigit((unsigned char)*q)) {
goto format_error; goto format_error;
} }
while (q[0] == '0' && isdigit((unsigned char)q[1])) { while (q[0] == '0' && isdigit((unsigned char)q[1])) {
@ -199,7 +199,7 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
q++; q++;
while (true) { while (true) {
if (!isdigit(*q)) { if (!isdigit((unsigned char)*q)) {
goto format_error; goto format_error;
} }
while (q[0] == '0' && isdigit((unsigned char)q[1])) { while (q[0] == '0' && isdigit((unsigned char)q[1])) {