sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Code

libsmb: fix regression on smbc_getxattr and fix doc

Browse Source 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14808
Signed-off-by: Remi Collet <rcollet@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Remi Collet 2023-04-04 10:22:09 +02:00 committed by Volker Lendecke
parent a1231c15ff
commit 4fc166628f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source3/include/libsmbclient.h
View File

@ -2419,7 +2419,7 @@ int smbc_getxattr(const char *url,
* required to hold the attribute value will be returned, * required to hold the attribute value will be returned,
* but nothing will be placed into the value buffer. * but nothing will be placed into the value buffer.
* *
* @return 0 on success, < 0 on error with errno set: * @return size on success, < 0 on error with errno set:
* - EINVAL The client library is not properly initialized * - EINVAL The client library is not properly initialized
* or one of the parameters is not of a correct * or one of the parameters is not of a correct
* form * form

4
source3/libsmb/libsmb_xattr.c
View File

@ -2182,9 +2182,9 @@ SMBC_getxattr_ctx(SMBCCTX *context,
TALLOC_FREE(frame); TALLOC_FREE(frame);
/* /*
* static function cacl_get returns a value greater than zero * static function cacl_get returns a value greater than zero
* on success. Map this to zero meaning success. * which is needed buffer size needed when size_t is 0.
*/ */
return ret < 0 ? -1 : 0; return ret;
} }
/* Unsupported attribute name */ /* Unsupported attribute name */