1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00

r9492: it is more usual to return 'undefined' instead of 'false' on a call failing (unless the

call is returning a boolean anyway).

Unfortunately the new GetOptions syntax loses the ability for the caller to know why the
command line arguments were bad. Maybe we would be better always returning an object and
having an is_error element?
This commit is contained in:
Andrew Tridgell 2005-08-22 23:33:47 +00:00 committed by Gerald (Jerry) Carter
parent 1ead49f8e8
commit 516ba6d20b

View File

@ -156,7 +156,7 @@ static int ejs_GetOptions(MprVarHandle eid, int argc, struct MprVar **argv)
poptStrerror(opt));
mprSetVar(options, "ERROR", mprString(err));
talloc_free(tmp_ctx);
mpr_Return(eid, mprCreateBoolVar(0));
mpr_Return(eid, mprCreateUndefinedVar());
return 0;
}
opt -= BASE_OPTNUM;