sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-08 04:58:40 +03:00
Code

s3: smbd - open logic fix.

Browse Source 
As we atomically create using O_CREAT|O_EXCL,
then if new_file_created is true, then
file_existed *MUST* have been false (even
if the file was previously detected as being
there.

We use the variable file_existed again in logic
below this statement, so we must set file_existed = false,
if new_file_created returns are true from open_file().

Based on a fix from Michael Adam.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10809

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Sep 11 22:29:22 CEST 2014 on sn-devel-104
This commit is contained in:
Jeremy Allison 2014-09-11 10:03:01 -07:00 committed by Michael Adam
parent 4e5a6b154e
commit 518247bf80
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source3/smbd/open.c
View File

@ -2489,6 +2489,17 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
return fsp_open;
}
if (new_file_created) {
/*
* As we atomically create using O_CREAT|O_EXCL,
* then if new_file_created is true, then
* file_existed *MUST* have been false (even
* if the file was previously detected as being
* there).
*/
file_existed = false;
}
if (file_existed && !check_same_dev_ino(&saved_stat, &smb_fname->st)) {
/*
* The file did exist, but some other (local or NFS)