sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Code

Fix bug 5696. The problem was when smbd

Browse Source 
was asking for a winbindd name to SID lookup of
"Unix Group\name" where "name" was also a valid username,
the winbindd passdb lookup of that name was losing the
domain string info before calling lookup name (ie. lookup_name()
was being called with just the string "name", not the
full string "Unix Group\name").

The passdb backend of winbindd has to cope with
not only names from it's own global SAM domain,
but it does lookups for BUILTIN and "Unix User"
and "Unix Group" also, so making it guess by
losing the domain string is "A Bad Idea" (tm) :-).

Note that as winbind globally calls winbind_off()
at startup, it's safe for winbind to call sys_getgrnam()
to do the "Unix Group" lookup from inside lookup_name().

Jeremy.
This commit is contained in:
Jeremy Allison 2008-08-16 19:23:38 -07:00
parent f06070c188
commit 5293af6c3c
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source/winbindd/winbindd_passdb.c
View File

@ -94,6 +94,7 @@ static NTSTATUS name_to_sid(struct winbindd_domain *domain,
DOM_SID *sid,
enum lsa_SidType *type)
{
const char *fullname;
uint32 flags = LOOKUP_NAME_ALL;
switch ( original_cmd ) {
@ -107,12 +108,27 @@ static NTSTATUS name_to_sid(struct winbindd_domain *domain,
break;
}
DEBUG(10, ("Finding name %s\n", name));
if (domain_name && domain_name[0] && strchr_m(name, '\\') == NULL) {
fullname = talloc_asprintf(mem_ctx, "%s\\%s",
domain_name, name);
if (fullname == NULL) {
return NT_STATUS_NO_MEMORY;
}
} else {
fullname = name;
}
if ( !lookup_name( mem_ctx, name, flags, NULL, NULL, sid, type ) ) {
DEBUG(10, ("Finding fullname %s\n", fullname));
if ( !lookup_name( mem_ctx, fullname, flags, NULL, NULL, sid, type ) ) {
return NT_STATUS_NONE_MAPPED;
}
DEBUG(10, ("name_to_sid for %s returned %s (%s)\n",
fullname,
sid_string_dbg(sid),
sid_type_lookup((uint32)*type)));
return NT_STATUS_OK;
}