sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-03 01:18:10 +03:00
Code

s4:rpc_server/netlogon: fix error codes in dcesrv_netr_NetrLogonSendToSam

Browse Source 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Dec  5 17:46:49 UTC 2024 on atb-devel-224
This commit is contained in:
Stefan Metzmacher 2024-11-25 18:25:52 +01:00
parent a382636fc2
commit 531a33b9c9
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
selftest/knownfail.d/samba.tests.krb5.netlogon
View File

@ -1,7 +1,5 @@
# Without AES we currently get DOWNGRADE_DETECTED
^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_.*_auth3_00004004
^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_.*_auth3_603fffff
# These need to be checked
^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_send_to_sam
# This is not implemented yet
^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_ticket_samlogon

7
source4/rpc_server/netlogon/dcerpc_netlogon.c
View File

@ -3234,7 +3234,7 @@ static NTSTATUS dcesrv_netr_NetrLogonSendToSam(struct dcesrv_call_state *dce_cal
case SEC_CHAN_DNS_DOMAIN:
case SEC_CHAN_DOMAIN:
case SEC_CHAN_NULL:
return NT_STATUS_INVALID_PARAMETER;
return NT_STATUS_ACCESS_DENIED;
default:
DEBUG(1, ("Client asked for an invalid secure channel type: %d\n",
creds->secure_channel_type));
@ -3264,8 +3264,7 @@ static NTSTATUS dcesrv_netr_NetrLogonSendToSam(struct dcesrv_call_state *dce_cal
(ndr_pull_flags_fn_t)ndr_pull_netr_SendToSamBase);
if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
/* We only partially implement SendToSam */
return NT_STATUS_NOT_IMPLEMENTED;
return NT_STATUS_INVALID_PARAMETER;
}
/* Now 'send' to SAM */
@ -3289,7 +3288,7 @@ static NTSTATUS dcesrv_netr_NetrLogonSendToSam(struct dcesrv_call_state *dce_cal
&dn);
if (ret != LDB_SUCCESS) {
ldb_transaction_cancel(sam_ctx);
return NT_STATUS_INVALID_PARAMETER;
return NT_STATUS_OBJECT_NAME_NOT_FOUND;
}
if (creds->secure_channel_type == SEC_CHAN_RODC &&