sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-28 01:58:17 +03:00
Code

s3:cleanupd: sends MSG_SMB_UNLOCK twice to interested peers

Browse Source 
MSG_SMB_UNLOCK should be send to smbd that are waiting on blocked
byte-range-locks when a lock holder died.

In smbd_cleanupd_unlock() we do this twice: once via a broadcast and
then again via brl_revalidate() to processes that are actually recorded
in brlock.tdb.

As brl_revalidate() should already take care of signaling anyone who
would be interested in the message, there's no need to broadcast.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13416

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May  4 03:02:28 CEST 2018 on sn-devel-144
This commit is contained in:
Ralph Boehme 2018-05-01 09:53:36 +02:00 committed by Jeremy Allison
parent d3b9d11bad
commit 53ff08a2cf
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source3/smbd/smbd_cleanupd.c
View File

@ -98,8 +98,6 @@ static void smbd_cleanupd_unlock(struct messaging_context *msg,
DBG_WARNING("Cleaning up brl and lock database after unclean "
"shutdown\n");
messaging_send_all(msg, MSG_SMB_UNLOCK, NULL, 0);
brl_revalidate(msg, private_data, msg_type, server_id, data);
}