sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4/dns_common_replace: add comments about tombstones

Browse Source 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2021-06-18 15:31:42 +12:00 committed by Andrew Bartlett
parent 26bb958af8
commit 54b9271eb5
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
source4/dns_server/dnsserver_common.c
View File

@ -1012,6 +1012,25 @@ WERROR dns_common_replace(struct ldb_context *samdb,
enum ndr_err_code ndr_err;
if (records[i].wType == DNS_TYPE_TOMBSTONE) {
/*
* There are two things that could be going on here.
*
* 1. We use a tombstone with EntombedTime == 0 for
* passing deletion messages through the stack, and
* this is the place we filter them out to perform
* that deletion.
*
* 2. This node is tombstoned, with no records except
* for a single tombstone, and it is just waiting to
* disappear. In this case, unless the caller has
* added a record, rec_count should be 1, and
* el->num_values will end up at 0, and we will make
* no changes. But if the caller has added a record,
* we need to un-tombstone the node.
*
* It is not possible to add an explicit tombstone
* record.
*/
if (records[i].data.EntombedTime != 0) {
was_tombstoned = true;
}
@ -1065,6 +1084,10 @@ WERROR dns_common_replace(struct ldb_context *samdb,
}
if (el->num_values == 0) {
/*
* We get here if there are no records or all the records were
* tombstones.
*/
struct dnsp_DnssrvRpcRecord tbs;
struct ldb_val *v = &el->values[el->num_values];
enum ndr_err_code ndr_err;