sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-07 17:18:11 +03:00
Code

ctdb-daemon: Don't mark a node as unhealthy when connecting to it

Browse Source 
Remote nodes are already initialised as UNHEALTHY when the node list
is initialised at startup (ctdb_load_nodes_file() calls
convert_node_map_to_list()) and when disconnected (ctdb_node_dead()).
So, drop this code.

RN: Fix CTDB flag/status update race conditions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14784
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Sep  9 02:38:34 UTC 2021 on sn-devel-184

(cherry picked from commit 9e7d2d9794)

Autobuild-User(v4-14-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-14-test): Tue Sep 14 07:37:32 UTC 2021 on sn-devel-184
This commit is contained in:
Martin Schwenke 2021-07-09 17:25:32 +10:00 committed by Jule Anger
parent 2d6cf082db
commit 551a39d890
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ctdb/server/ctdb_server.c
View File

@ -337,7 +337,6 @@ void ctdb_node_connected(struct ctdb_node *node)
node->ctdb->num_connected++;
node->dead_count = 0;
node->flags &= ~NODE_FLAGS_DISCONNECTED;
node->flags |= NODE_FLAGS_UNHEALTHY;
DEBUG(DEBUG_ERR,
("%s: connected to %s - %u connected\n",
node->ctdb->name, node->name, node->ctdb->num_connected));