sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-23 06:50:21 +03:00
Code

smbd: Save a few lines in file_set_dosmode() with "goto done;"

Browse Source 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Volker Lendecke 2022-03-03 21:49:47 +01:00 committed by Ralph Boehme
parent 2976177005
commit 5567d5bca2
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source3/smbd/dosmode.c
View File

@ -958,13 +958,8 @@ int file_set_dosmode(connection_struct *conn,
}
if (NT_STATUS_IS_OK(status)) {
if (!newfile) {
notify_fname(conn, NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_ATTRIBUTES,
smb_fname->base_name);
}
smb_fname->st.st_ex_mode = unixmode;
return 0;
ret = 0;
goto done;
}
/*
@ -1039,13 +1034,7 @@ int file_set_dosmode(connection_struct *conn,
ret = SMB_VFS_FCHMOD(smb_fname->fsp, unixmode);
if (ret == 0) {
if (!newfile) {
notify_fname(conn, NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_ATTRIBUTES,
smb_fname->base_name);
}
smb_fname->st.st_ex_mode = unixmode;
return 0;
goto done;
}
if((errno != EPERM) && (errno != EACCES))
@ -1068,6 +1057,7 @@ int file_set_dosmode(connection_struct *conn,
ret = SMB_VFS_FCHMOD(smb_fname->fsp, unixmode);
unbecome_root();
done:
if (!newfile) {
notify_fname(conn, NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_ATTRIBUTES,