sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-05 20:58:40 +03:00
Code

auth:credentials: avoid talloc_reference in cli_credentials_set_netlogon_creds()

Browse Source 
Typically cli_credentials_set_netlogon_creds() should be used directly
before the DCERPC bind. And cli_credentials_get_netlogon_creds()
should be only used by the gensec layer, which only needs a copy.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct 16 23:56:01 CEST 2013 on sn-devel-104
This commit is contained in:
Stefan Metzmacher 2013-09-20 04:33:07 +02:00 committed by Andrew Bartlett
parent a62927ef88
commit 556f66bd56
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
auth/credentials/credentials.c
View File

@ -836,7 +836,11 @@ _PUBLIC_ void cli_credentials_guess(struct cli_credentials *cred,
_PUBLIC_ void cli_credentials_set_netlogon_creds(struct cli_credentials *cred,
struct netlogon_creds_CredentialState *netlogon_creds)
{
cred->netlogon_creds = talloc_reference(cred, netlogon_creds);
TALLOC_FREE(cred->netlogon_creds);
if (netlogon_creds == NULL) {
return;
}
cred->netlogon_creds = netlogon_creds_copy(cred, netlogon_creds);
}
/**