sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

rpc_server3: Remove dcerpc_ncacn_conn->session_info

Browse Source 
This was only used inside rpc_worker_new_client(), a leftover from
times where accepting a client was an async process waiting for the
struct named_pipe_auth_req_info4.

The talloc hierarchy is correctly maintained, dcesrv_endpoint_connect() takes a
talloc_reference() of session_info.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2021-10-06 11:16:21 +02:00 committed by Jeremy Allison
parent 79024fa681
commit 55cdb61269
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source3/rpc_server/rpc_server.h
View File

@ -43,7 +43,6 @@ struct dcerpc_ncacn_conn {
char *remote_client_name; char *remote_client_name;
char *local_server_name; char *local_server_name;
struct auth_session_info *session_info;
}; };
void set_incoming_fault(struct pipes_struct *p); void set_incoming_fault(struct pipes_struct *p);

7
source3/rpc_server/rpc_worker.c
View File

@ -376,11 +376,8 @@ static void rpc_worker_new_client(
} }
sock = -1; sock = -1;
ncacn_conn->session_info = talloc_move(
ncacn_conn, &info5->session_info->session_info);
if (security_token_is_system( if (security_token_is_system(
ncacn_conn->session_info->security_token) && info5->session_info->session_info->security_token) &&
(transport != NCALRPC)) { (transport != NCALRPC)) {
DBG_DEBUG("System token only allowed on NCALRPC\n"); DBG_DEBUG("System token only allowed on NCALRPC\n");
goto fail; goto fail;
@ -398,7 +395,7 @@ static void rpc_worker_new_client(
dce_ctx, dce_ctx,
ncacn_conn, ncacn_conn,
ep, ep,
ncacn_conn->session_info, info5->session_info->session_info,
global_event_context(), global_event_context(),
DCESRV_CALL_STATE_FLAG_MAY_ASYNC, DCESRV_CALL_STATE_FLAG_MAY_ASYNC,
&dcesrv_conn); &dcesrv_conn);