sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

torture: avoid OPLOCK-CANCEL flapping on busy gitlab CI

Browse Source 
I saw this test fail a few times on gitlab CI with
NT_STATUS_SHARING_VIOLATION:

  Running OPLOCK-CANCEL
  cli_unlink failed: NT_STATUS_SHARING_VIOLATION
  TEST OPLOCK-CANCEL FAILED!

The only possible explanation I could come up for
this flapping test is that the fnum1 filehandle in cli1 is still not closed when
cli2 tries to open the file deletion 5 seconds after cli1 is thrown away. As
fnum1 doesn't have FILE_SHARE_DELELE the open-for-delete fails with a
SHARING_VIOLATION.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2020-11-16 10:44:48 +01:00 committed by Jeremy Allison
parent 4dbb8fda4e
commit 5604afefb0
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source3/torture/test_oplock_cancel.c
View File

@ -148,6 +148,8 @@ bool run_oplock_cancel(int dummy)
return false; return false;
} }
cli_close(cli1, fnum1);
TALLOC_FREE(cli1); TALLOC_FREE(cli1);
/* /*