sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-28 01:58:17 +03:00
Code

s4:auth_sam: allow logons with an empty domain name

Browse Source 
It turns out that an empty domain name maps to the local SAM.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13206

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb 23 04:08:26 CET 2018 on sn-devel-144
This commit is contained in:
Stefan Metzmacher 2018-01-09 08:54:11 +01:00 committed by Andrew Bartlett
parent 2e49a97777
commit 57762229da
3 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/empty-domain-bind
View File

@ -1 +0,0 @@
^samba4.ldap.bind\(fl2008r2dc\).__main__.BindTests.test_user_account_bind_no_domain.*

1
selftest/knownfail.d/empty-domain-samlogon
View File

@ -1 +0,0 @@
^samba.tests.py_credentials.samba.tests.py_credentials.PyCredentialsTests.test_SamLogonEx_no_domain

16
source4/auth/ntlm/auth_sam.c
View File

@ -739,6 +739,10 @@ static NTSTATUS authsam_want_check(struct auth_method_context *ctx,
return NT_STATUS_NOT_IMPLEMENTED;
}
if (effective_domain == NULL) {
effective_domain = "";
}
is_local_name = lpcfg_is_myname(ctx->auth_ctx->lp_ctx,
effective_domain);
@ -784,7 +788,7 @@ static NTSTATUS authsam_want_check(struct auth_method_context *ctx,
return NT_STATUS_NOT_IMPLEMENTED;
}
if (effective_domain != NULL && !strequal(effective_domain, "")) {
if (!strequal(effective_domain, "")) {
DBG_DEBUG("%s is not one domain name (DC)\n",
effective_domain);
return NT_STATUS_NOT_IMPLEMENTED;
@ -792,11 +796,11 @@ static NTSTATUS authsam_want_check(struct auth_method_context *ctx,
p = strchr_m(user_info->mapped.account_name, '@');
if (p == NULL) {
if (effective_domain == NULL) {
return NT_STATUS_OK;
}
DEBUG(6,("authsam_check_password: '' without upn not handled (DC)\n"));
return NT_STATUS_NOT_IMPLEMENTED;
/*
* An empty to domain name should be handled
* as the local domain name.
*/
return NT_STATUS_OK;
}
effective_domain = p + 1;