sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Code

s3:utils: let net_update_dns_internal() set status before goto done in all cases

Browse Source 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Stefan Metzmacher 2024-05-11 02:38:21 +02:00
parent 28af082926
commit 5807689f96
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source3/utils/net_ads_join_dns.c
View File

@ -88,6 +88,7 @@ static NTSTATUS net_update_dns_internal(struct net_context *c,
ads_status = ads_connect( ads );
if ( !ADS_ERR_OK(ads_status) ) {
DEBUG(0,("net_update_dns_internal: Failed to connect to our DC!\n"));
status = ads_ntstatus(ads_status);
goto done;
}
}
@ -95,12 +96,14 @@ static NTSTATUS net_update_dns_internal(struct net_context *c,
ads_status = ads_do_search(ads, "", LDAP_SCOPE_BASE,
"(objectclass=*)", rootname_attrs, &msg);
if (!ADS_ERR_OK(ads_status)) {
status = ads_ntstatus(ads_status);
goto done;
}
root_dn = ads_pull_string(ads, ctx, msg, "rootDomainNamingContext");
if ( !root_dn ) {
ads_msgfree( ads, msg );
status = NT_STATUS_INVALID_NETWORK_RESPONSE;
goto done;
}