sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

make sure the ctdb control socket is secure

Browse Source 
(This used to be ctdb commit 2954f2e501a418af578e75e8705b0b39a77c1861)
This commit is contained in:
Andrew Tridgell 2007-05-13 09:20:16 +10:00
parent 81826da2df
commit 5839eb1e80
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ctdb/common/ctdb_daemon.c
View File

@ -600,10 +600,15 @@ static int ux_socket_bind(struct ctdb_context *ctdb)
ctdb->daemon.sd = socket(AF_UNIX, SOCK_STREAM, 0);
if (ctdb->daemon.sd == -1) {
ctdb->daemon.sd = -1;
return -1;
}
if (fchown(ctdb->daemon.sd, geteuid(), getegid()) != 0 ||
fchmod(ctdb->daemon.sd, 0700) != 0) {
DEBUG(0,("Unable to secure ctdb socket '%s', ctdb->daemon.name\n"));
goto failed;
}
set_non_blocking(ctdb->daemon.sd);
memset(&addr, 0, sizeof(addr));
@ -611,13 +616,20 @@ static int ux_socket_bind(struct ctdb_context *ctdb)
strncpy(addr.sun_path, ctdb->daemon.name, sizeof(addr.sun_path));
if (bind(ctdb->daemon.sd, (struct sockaddr *)&addr, sizeof(addr)) == -1) {
close(ctdb->daemon.sd);
ctdb->daemon.sd = -1;
return -1;
DEBUG(0,("Unable to bind on ctdb socket '%s', ctdb->daemon.name\n"));
goto failed;
}
listen(ctdb->daemon.sd, 1);
if (listen(ctdb->daemon.sd, 10) != 0) {
DEBUG(0,("Unable to listen on ctdb socket '%s', ctdb->daemon.name\n"));
goto failed;
}
return 0;
failed:
close(ctdb->daemon.sd);
ctdb->daemon.sd = -1;
return -1;
}
/*