sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-24 02:04:21 +03:00
Code

dbwrap_ctdb: only fetch a read-only copy if we had a record already.

Browse Source 
Because revoking read-only copies of records is expensive, we only
want ctdbd to do it for high-turnover records.  A basic heuristic is
that if we don't find a local copy of the record, don't ask for a
read-only copy.

The fetch itself will cause ctdbd to migrate the record, so eventually
we will have a local copy.  Next time it gets migrated away, we'll
call ctdbd_fetch() with local_copy = true.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2012-02-03 11:00:54 +11:00 committed by Amitay Isaacs
parent 67bb5abe81
commit 5bda068773
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source3/include/ctdbd_conn.h
View File

@ -60,7 +60,8 @@ NTSTATUS ctdbd_migrate(struct ctdbd_connection *conn, uint32 db_id,
TDB_DATA key);
NTSTATUS ctdbd_fetch(struct ctdbd_connection *conn, uint32 db_id,
TDB_DATA key, TALLOC_CTX *mem_ctx, TDB_DATA *data);
TDB_DATA key, TALLOC_CTX *mem_ctx, TDB_DATA *data,
bool local_copy);
NTSTATUS ctdbd_traverse(uint32 db_id,
void (*fn)(TDB_DATA key, TDB_DATA data,

5
source3/lib/ctdbd_conn.c
View File

@ -1394,7 +1394,8 @@ NTSTATUS ctdbd_migrate(struct ctdbd_connection *conn, uint32 db_id,
* remotely fetch a record (read-only)
*/
NTSTATUS ctdbd_fetch(struct ctdbd_connection *conn, uint32 db_id,
TDB_DATA key, TALLOC_CTX *mem_ctx, TDB_DATA *data)
TDB_DATA key, TALLOC_CTX *mem_ctx, TDB_DATA *data,
bool local_copy)
{
struct ctdb_req_call req;
struct ctdb_reply_call *reply;
@ -1407,7 +1408,7 @@ NTSTATUS ctdbd_fetch(struct ctdbd_connection *conn, uint32 db_id,
req.hdr.ctdb_version = CTDB_VERSION;
req.hdr.operation = CTDB_REQ_CALL;
req.hdr.reqid = ctdbd_next_reqid(conn);
req.flags = CTDB_WANT_READONLY;
req.flags = local_copy ? CTDB_WANT_READONLY : 0;
req.callid = CTDB_FETCH_FUNC;
req.db_id = db_id;
req.keylen = key.dsize;

9
source3/lib/dbwrap/dbwrap_ctdb.c
View File

@ -1203,9 +1203,14 @@ static NTSTATUS db_ctdb_fetch(struct db_context *db, TALLOC_CTX *mem_ctx,
SAFE_FREE(ctdb_data.dptr);
/* we weren't able to get it locally - ask ctdb to fetch it for us */
/*
* We weren't able to get it locally - ask ctdb to fetch it for us.
* If we already had *something*, it's probably worth making a local
* read-only copy.
*/
status = ctdbd_fetch(messaging_ctdbd_connection(), ctx->db_id, key,
mem_ctx, data);
mem_ctx, data,
ctdb_data.dsize >= sizeof(struct ctdb_ltdb_header));
if (!NT_STATUS_IS_OK(status)) {
DEBUG(5, ("ctdbd_fetch failed: %s\n", nt_errstr(status)));
}