sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

util/base64: add a note about zero length strings

Browse Source 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2022-05-13 10:59:24 +12:00 committed by Andrew Bartlett
parent c3ded9d934
commit 5c007600dc
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/util/base64.c
View File

@ -115,8 +115,16 @@ _PUBLIC_ char *base64_encode_data_blob(TALLOC_CTX *mem_ctx, DATA_BLOB data)
size_t out_cnt, len, output_len; size_t out_cnt, len, output_len;
char *result; char *result;
if (!data.length || !data.data) /*
* Note: we return NULL for a zero-length blob, even though it can be
* encoded as a zero length string in base64.
*
* FIXME, perhaps, but we need to check carefully before changing
* this.
*/
if (data.length == 0 || data.data == NULL) {
return NULL; return NULL;
}
out_cnt = 0; out_cnt = 0;
len = data.length; len = data.length;