sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-03 01:18:10 +03:00
Code

libgpo: Use dom_sid_str_buf

Browse Source 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2018-11-02 21:28:59 +01:00 committed by Jeremy Allison
parent 87ae595b38
commit 5cad0fc6c0
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libgpo/gpo_sec.c
View File

@ -103,16 +103,13 @@ static bool gpo_sd_check_read_access_bits(uint32_t access_mask)
static NTSTATUS gpo_sd_check_ace_denied_object(const struct security_ace *ace, static NTSTATUS gpo_sd_check_ace_denied_object(const struct security_ace *ace,
const struct security_token *token) const struct security_token *token)
{ {
char *sid_str;
if (gpo_sd_check_agp_object(ace) && if (gpo_sd_check_agp_object(ace) &&
gpo_sd_check_agp_access_bits(ace->access_mask) && gpo_sd_check_agp_access_bits(ace->access_mask) &&
security_token_has_sid(token, &ace->trustee)) { security_token_has_sid(token, &ace->trustee)) {
sid_str = dom_sid_string(NULL, &ace->trustee); struct dom_sid_buf sid_str;
DEBUG(10,("gpo_sd_check_ace_denied_object: " DEBUG(10,("gpo_sd_check_ace_denied_object: "
"Access denied as of ace for %s\n", "Access denied as of ace for %s\n",
sid_str)); dom_sid_str_buf(&ace->trustee, &sid_str)));
talloc_free(sid_str);
return NT_STATUS_ACCESS_DENIED; return NT_STATUS_ACCESS_DENIED;
} }
@ -125,17 +122,13 @@ static NTSTATUS gpo_sd_check_ace_denied_object(const struct security_ace *ace,
static NTSTATUS gpo_sd_check_ace_allowed_object(const struct security_ace *ace, static NTSTATUS gpo_sd_check_ace_allowed_object(const struct security_ace *ace,
const struct security_token *token) const struct security_token *token)
{ {
char *sid_str;
if (gpo_sd_check_agp_object(ace) && if (gpo_sd_check_agp_object(ace) &&
gpo_sd_check_agp_access_bits(ace->access_mask) && gpo_sd_check_agp_access_bits(ace->access_mask) &&
security_token_has_sid(token, &ace->trustee)) { security_token_has_sid(token, &ace->trustee)) {
sid_str = dom_sid_string(NULL, &ace->trustee); struct dom_sid_buf sid_str;
DEBUG(10,("gpo_sd_check_ace_allowed_object: " DEBUG(10,("gpo_sd_check_ace_allowed_object: "
"Access granted as of ace for %s\n", "Access granted as of ace for %s\n",
sid_str)); dom_sid_str_buf(&ace->trustee, &sid_str)));
talloc_free(sid_str);
return NT_STATUS_OK; return NT_STATUS_OK;
} }