1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

amazing! we've had a reversed comparison in our blocking lock code

since 1998 and nobody noticed. It means that sometimes smbd would sit
there forever, and smbd would never get the timing part of blocking
locks right.
This commit is contained in:
Andrew Tridgell -
parent 227472286f
commit 5d4df58b6d

View File

@ -576,7 +576,7 @@ void process_blocking_lock_queue(time_t t)
DEBUG(5,("process_blocking_lock_queue: examining pending lock fnum = %d for file %s\n",
fsp->fnum, fsp->fsp_name ));
if((blr->expire_time != -1) && (blr->expire_time > t)) {
if((blr->expire_time != -1) && (blr->expire_time <= t)) {
/*
* Lock expired - throw away all previously
* obtained locks and return lock error.