sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

Fix mem leak with PyBytes_FromStringAndSize

Browse Source 
Reviewed-by: Andrew Bartlett abartlet@samba.org
This commit is contained in:
Noel Power 2019-01-28 15:23:48 +00:00 committed by Noel Power
parent 30d505e91b
commit 5dad03b83c
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source4/auth/gensec/pygensec.c
View File

@ -453,7 +453,7 @@ static PyObject *py_gensec_update(PyObject *self, PyObject *args)
NTSTATUS status;
TALLOC_CTX *mem_ctx;
DATA_BLOB in, out;
PyObject *ret, *py_in;
PyObject *py_bytes, *result, *py_in;
struct gensec_security *security = pytalloc_get_type(self, struct gensec_security);
PyObject *finished_processing;
@ -477,7 +477,8 @@ static PyObject *py_gensec_update(PyObject *self, PyObject *args)
talloc_free(mem_ctx);
return NULL;
}
ret = PyBytes_FromStringAndSize((const char *)out.data, out.length);
py_bytes = PyBytes_FromStringAndSize((const char *)out.data,
out.length);
talloc_free(mem_ctx);
if (NT_STATUS_EQUAL(status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
@ -486,7 +487,9 @@ static PyObject *py_gensec_update(PyObject *self, PyObject *args)
finished_processing = Py_True;
}
return PyTuple_Pack(2, finished_processing, ret);
result = PyTuple_Pack(2, finished_processing, py_bytes);
Py_XDECREF(py_bytes);
return result;
}
static PyObject *py_gensec_wrap(PyObject *self, PyObject *args)