1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-29 02:50:28 +03:00

s3:smbd: document the interaction between "smb2 leases" and "write cache size"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Stefan Metzmacher 2014-11-08 09:45:59 +01:00 committed by Jeremy Allison
parent 7eae9460a3
commit 5e251adbed
3 changed files with 11 additions and 0 deletions

View File

@ -16,6 +16,8 @@
and <smbconfoption name="kernel oplocks">no</smbconfoption>.
</para>
<para>Note that the write cache won't be used for file handles with a smb2 write lease.</para>
<para>
The Samba implementation of leases is currently marked as experimental!
</para>
@ -24,5 +26,6 @@
<related>oplocks</related>
<related>kernel oplocks</related>
<related>level2 oplocks</related>
<related>write cache size</related>
<value type="default">no</value>
</samba:parameter>

View File

@ -21,8 +21,11 @@
<para>The integer parameter specifies the size of this cache
(per oplocked file) in bytes.</para>
<para>Note that the write cache won't be used for file handles with a smb2 write lease.</para>
</description>
<related>smb2 leases</related>
<value type="default">0</value>
<value type="example">262144<comment> for a 256k cache size per file</comment></value>
</samba:parameter>

View File

@ -339,6 +339,11 @@ ssize_t write_file(struct smb_request *req,
if (!fsp->modified &&
EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type) &&
(wcp == NULL)) {
/*
* Note: no write cache with leases!
* as the handles would have to share the write cache
* that's possible but an improvement for another day...
*/
setup_write_cache(fsp, fsp->fsp_name->st.st_ex_size);
wcp = fsp->wcp;
}