sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-22 02:50:28 +03:00
Code

s3/auth: use talloc_alpha_strcpy() in create_local_token()

Browse Source 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Ralph Boehme 2020-01-17 19:28:13 +01:00 committed by Andreas Schneider
parent 276d280d27
commit 5e35d30b68
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
source3/auth/auth_util.c
View File

@ -478,7 +478,6 @@ NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
struct dom_sid tmp_sid;
struct auth_session_info *session_info;
struct unixid *ids;
fstring tmp;
/* Ensure we can't possible take a code path leading to a
* null defref. */
@ -494,9 +493,10 @@ NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
}
/* This is a potentially untrusted username for use in %U */
alpha_strcpy(tmp, smb_username, ". _-$", sizeof(tmp));
session_info->unix_info->sanitized_username =
talloc_strdup(session_info->unix_info, tmp);
talloc_alpha_strcpy(session_info->unix_info,
smb_username,
SAFE_NETBIOS_CHARS "$");
if (session_info->unix_info->sanitized_username == NULL) {
TALLOC_FREE(session_info);
return NT_STATUS_NO_MEMORY;
@ -535,9 +535,14 @@ NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
}
/* This is a potentially untrusted username for use in %U */
alpha_strcpy(tmp, smb_username, ". _-$", sizeof(tmp));
session_info->unix_info->sanitized_username =
talloc_strdup(session_info->unix_info, tmp);
talloc_alpha_strcpy(session_info->unix_info,
smb_username,
SAFE_NETBIOS_CHARS "$");
if (session_info->unix_info->sanitized_username == NULL) {
TALLOC_FREE(session_info);
return NT_STATUS_NO_MEMORY;
}
if (session_key) {
data_blob_free(&session_info->session_key);