sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

dosmode: prefer capabilities over become_root

Browse Source 
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Björn Jacke 2023-11-20 12:36:00 +01:00 committed by Andrew Bartlett
parent 1dd81928a2
commit 5e925f9755
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source3/smbd/dosmode.c
View File

@ -1035,9 +1035,9 @@ int file_set_dosmode(connection_struct *conn,
return -1;
}
become_root();
set_effective_capability(DAC_OVERRIDE_CAPABILITY);
ret = SMB_VFS_FCHMOD(smb_fname->fsp, unixmode);
unbecome_root();
drop_effective_capability(DAC_OVERRIDE_CAPABILITY);
done:
if (!newfile) {
@ -1205,9 +1205,9 @@ int file_ntimes(connection_struct *conn,
/* Check if we have write access. */
if (can_write_to_fsp(fsp)) {
/* We are allowed to become root and change the filetime. */
become_root();
set_effective_capability(DAC_OVERRIDE_CAPABILITY);
ret = SMB_VFS_FNTIMES(fsp, ft);
unbecome_root();
drop_effective_capability(DAC_OVERRIDE_CAPABILITY);
}
return ret;