sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Code

s4-rpc_server: Add comments explaining the control flow around dcesrv_bind()

Browse Source 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Andrew Bartlett 2016-12-14 09:38:28 +13:00
parent b38f1aee40
commit 5ea6708d81
1 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
source4/rpc_server/dcerpc_server.c
View File

@ -792,6 +792,14 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
/*
* Try to negotiate one new presentation context.
*
* Deep in here we locate the iface (by uuid) that the client
* requested, from the list of interfaces on the
* call->conn->endpoint, and call iface->bind() on that iface.
*
* call->conn was set up at the accept() of the socket, and
* call->conn->endpoint has a list of interfaces restricted to
* this port or pipe.
*/
status = dcesrv_negotiate_contexts(call, &call->pkt.u.bind, ack_ctx_list);
if (NT_STATUS_EQUAL(status, NT_STATUS_RPC_PROTOCOL_ERROR)) {
@ -801,6 +809,12 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
return status;
}
/*
* At this point we know which interface (eg netlogon, lsa,
* drsuapi) the caller requested. This is available on
* call->conntext->iface.
*/
if ((call->pkt.pfc_flags & DCERPC_PFC_FLAG_CONC_MPX) &&
(call->state_flags & DCESRV_CALL_STATE_FLAG_MULTIPLEXED)) {
call->conn->state_flags |= DCESRV_CALL_STATE_FLAG_MULTIPLEXED;
@ -811,7 +825,11 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
call->conn->state_flags |= DCESRV_CALL_STATE_FLAG_PROCESS_PENDING_CALL;
}
/* handle any authentication that is being requested */
/*
* After finding the interface and setting up the NDR
* transport negotiation etc, handle any authentication that
* is being requested.
*/
if (!dcesrv_auth_bind(call)) {
struct dcesrv_auth *auth = &call->conn->auth_state;
@ -2246,6 +2264,13 @@ static void dcesrv_sock_accept(struct stream_connection *srv_conn)
}
}
/*
* This fills in dcesrv_conn->endpoint with the endpoint
* associated with the socket. From this point on we know
* which (group of) services we are handling, but not the
* specific interface.
*/
status = dcesrv_endpoint_connect(dcesrv_sock->dcesrv_ctx,
srv_conn,
dcesrv_sock->endpoint,