1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00

lib/fuzzing and librpc: Do not generate fuzzers for pointless targets

We need to focus the fuzzing effort on reachable code, and these IDL
are just historical artifacts, many are entirely [todo] and have
no samba client nor server.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Andrew Bartlett 2019-12-13 15:34:34 +13:00
parent bbc4ebbcaf
commit 5eac5813cc
2 changed files with 8 additions and 17 deletions

View File

@ -97,7 +97,6 @@ bld.SAMBA_NDR_FUZZ('FileServerVssAgent') # fsvrp.idl
bld.SAMBA_NDR_FUZZ('lsarpc') # lsa.idl
bld.SAMBA_NDR_FUZZ('netdfs') # dfs.idl
bld.SAMBA_NDR_FUZZ('nfs4acl_interface') # nfs4acl.idl
bld.SAMBA_NDR_FUZZ('ObjectRpcBaseTypes') # orpc.idl
bld.SAMBA_NDR_FUZZ('rpcecho') # echo.idl
# quota.idl
@ -113,8 +112,6 @@ bld.SAMBA_NDR_FUZZ('sparse')
bld.SAMBA_NDR_FUZZ('resiliency')
bld.SAMBA_NDR_FUZZ('trim')
# Skipped: dsbackup (all todo)
# WMI tables
bld.SAMBA_NDR_FUZZ('IWbemClassObject')
bld.SAMBA_NDR_FUZZ('IWbemServices')

View File

@ -71,16 +71,22 @@ bld.SAMBA_PIDL_LIST('PIDL',
generate_fuzzers=False)
# DCE/RPC protocols which Samba does not implement a client or server
# for
# for. We don't generate a fuzzer for these as they are unreachable
#
# Do not include IDL with public structures in this list as we want to
# fuzz those
bld.SAMBA_PIDL_LIST('PIDL',
'''
audiosrv.idl
dbgidl.idl
dsbackup.idl
efs.idl
frstrans.idl
frsrpc.idl
keysvc.idl
msgsvc.idl
orpc.idl
policyagent.idl
rot.idl
scerpc.idl
@ -89,20 +95,9 @@ bld.SAMBA_PIDL_LIST('PIDL',
wzcsvc.idl
''',
options='--header --ndr-parser',
generate_fuzzers=False,
output_dir='../gen_ndr')
# The interface names here are not the same as the IDL name, so the
# auto-genration of the fuzzer fails to link
bld.SAMBA_PIDL_LIST('PIDL',
'''
dsbackup.idl
orpc.idl
''',
options='--header --ndr-parser',
output_dir='../gen_ndr',
generate_fuzzers=False)
# Non-DCE/RPC protocols encoded in IDL for Samba or helper IDLs for
# DCE/RPC protocols (eg defining constands or structures but not
# functions)
@ -110,7 +105,6 @@ bld.SAMBA_PIDL_LIST('PIDL',
'''
bkupblobs.idl
cab.idl
dbgidl.idl
file_id.idl
fscc.idl
fsrvp_state.idl